OSDN Git Service

net/mlx5: Fix static checker warnings
authorOr Gerlitz <ogerlitz@mellanox.com>
Thu, 8 Dec 2016 10:58:45 +0000 (12:58 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 6 Feb 2017 09:21:34 +0000 (11:21 +0200)
commita61d5ce9cc56e2e41bbb1ad62ca7a16d7e7567bd
treefc8d6cab55c600b118af9f693b6bac3f7d5a2c05
parentbd092ad1463ca0990581fa992e12a9b0ed295d25
net/mlx5: Fix static checker warnings

For some reason, sparse doesn't like using an expression of type (!x)
with a bitwise | and &.  In order to mitigate that, we use a local variable.

This removes the following sparse complaints on the core driver
(and similar ones on the IB driver too):

drivers/net/ethernet/mellanox/mlx5/core/srq.c:83:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/srq.c:96:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/port.c:59:9: warning: dubious: !x & y
drivers/net/ethernet/mellanox/mlx5/core/vport.c:561:9: warning: dubious: !x & y

Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Matan Barak <matanb@mellanox.com>
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
include/linux/mlx5/device.h