OSDN Git Service

dmaengine: xilinx_dma: Correctly handle cyclic descriptor callbacks
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 25 Oct 2021 07:54:27 +0000 (09:54 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 28 Oct 2021 17:23:54 +0000 (22:53 +0530)
commita63ddc38571ef32eb396eb81f50dca1c8d9b2432
tree3e6847e5c9f1ca02b99bdefd8af6caefe41ed6b6
parenta34da7ef9a8c2b89ddb84689562f3d2b48a4e588
dmaengine: xilinx_dma: Correctly handle cyclic descriptor callbacks

DMA clients can provide one of two types of callbacks. For this reason
dmaengine drivers should not directly invoke `callback`, but always use
`dmaengine_desc_callback_invoke()`. This makes sure that both types of
callbacks are handled correctly.

The xilinx_dma driver currently doesn't do this for cyclic descriptors and
only handles the `callback` type callback. If the client used the
`callback_result` type callback it will not be called.

Fix this by switching to `dmaengine_desc_callback_valid()` and
`dmaengine_desc_callback_invoke()`.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211025075428.2094-2-lars@metafoo.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xilinx/xilinx_dma.c