OSDN Git Service

net/ipv4: Use proper RCU APIs for writer-side in udp_offload.c
authorShlomo Pongratz <shlomop@mellanox.com>
Sun, 2 Feb 2014 13:42:10 +0000 (15:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Feb 2014 04:01:55 +0000 (20:01 -0800)
commita664a4f7aa4f01ca8728e3ec43618327416fc8ff
tree62866bf915a2074380ec6c066ee7330804b39cda
parent9330ed16da840b1b68cd99600d403b6f3e9fa4e2
net/ipv4: Use proper RCU APIs for writer-side in udp_offload.c

RCU writer side should use rcu_dereference_protected() and not
rcu_dereference(), fix that. This also removes the "suspicious RCU usage"
warning seen when running with CONFIG_PROVE_RCU.

Also, don't use rcu_assign_pointer/rcu_dereference for pointers
which are invisible beyond the udp offload code.

Fixes: b582ef0 ('net: Add GRO support for UDP encapsulating protocols')
Reported-by: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_offload.c