OSDN Git Service

perf/core: Fix reversed NULL check in perf_event_groups_less()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 12 Mar 2020 10:56:37 +0000 (13:56 +0300)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 20 Mar 2020 12:06:22 +0000 (13:06 +0100)
commita6763625ae6f8aa5ee82fcd8fa4e5e38db20dbc6
tree27eaffee9c26ceed5840810875d14e3648e96bc2
parent90c91dfb86d0ff545bd329d3ddd72c147e2ae198
perf/core: Fix reversed NULL check in perf_event_groups_less()

This NULL check is reversed so it leads to a Smatch warning and
presumably a NULL dereference.

    kernel/events/core.c:1598 perf_event_groups_less()
    error: we previously assumed 'right->cgrp->css.cgroup' could be null
(see line 1590)

Fixes: 95ed6c707f26 ("perf/cgroup: Order events in RB tree by cgroup id")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200312105637.GA8960@mwanda
kernel/events/core.c