OSDN Git Service

mm/madvise: remove racy mm ownership check
authorMinchan Kim <minchan@kernel.org>
Wed, 9 Dec 2020 04:57:18 +0000 (20:57 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 9 Dec 2020 04:57:18 +0000 (20:57 -0800)
commita68a0262abdaa251e12c53715f48e698a18ef402
tree6db05d544c83a19e040d329db4b623e245ec3393
parent4cb682964706deffb4861f0a91329ab3a705039f
mm/madvise: remove racy mm ownership check

Jann spotted the security hole due to race of mm ownership check.

If the task is sharing the mm_struct but goes through execve() before
mm_access(), it could skip process_madvise_behavior_valid check.  That
makes *any advice hint* to reach into the remote process.

This patch removes the mm ownership check.  With it, it will lose the
ability that local process could give *any* advice hint with vector
interface for some reason (e.g., performance).  Since there is no
concrete example in upstream yet, it would be better to remove the
abiliity at this moment and need to review when such new advice comes
up.

Fixes: ecb8ac8b1f14 ("mm/madvise: introduce process_madvise() syscall: an external memory hinting API")
Reported-by: Jann Horn <jannh@google.com>
Suggested-by: Jann Horn <jannh@google.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/madvise.c