OSDN Git Service

drm/amdgpu: Fixes to returning VBIOS RAS EEPROM address
authorLuben Tuikov <luben.tuikov@amd.com>
Tue, 24 Aug 2021 15:01:32 +0000 (11:01 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 30 Aug 2021 18:59:33 +0000 (14:59 -0400)
commita6a355a22f7a0efa6a11bc90b5161f394d51fe95
tree40d3fb53af720f92593c9d669efe6eeb437d1408
parentfbd2a6003a259fe12750ceb5efc47432c3cc7ce4
drm/amdgpu: Fixes to returning VBIOS RAS EEPROM address

1) Generalize the function--if the user didn't set
   i2c_address, still return true/false to
   indicate whether VBIOS contains the RAS EEPROM
   address.  This function shouldn't evaluate
   whether the user set the i2c_address pointer or
   not.

2) Don't touch the caller's i2c_address, unless
   you have to--this function shouldn't have side
   effects.

3) Correctly set the function comment as a
   kernel-doc comment.

Cc: John Clements <john.clements@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
Reviewed-by: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c