OSDN Git Service

scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 25 Jan 2018 14:27:27 +0000 (17:27 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 Jan 2018 02:32:06 +0000 (21:32 -0500)
commita7043e9529f3c367cc4d82997e00be034cbe57ca
treec45139a48317508144e8d670a7d8507abc4f22b5
parente6f791d95313c85f3dd4a26141e28e50ae9aa0ae
scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()

My static checker complains about an out of bounds read:

    drivers/message/fusion/mptctl.c:2786 mptctl_hp_targetinfo()
    error: buffer overflow 'hd->sel_timeout' 255 <= u32max.

It's true that we probably should have a bounds check here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptctl.c