OSDN Git Service

ethtool: fix stack overflow in ethnl_parse_bitset()
authorMichal Kubecek <mkubecek@suse.cz>
Tue, 8 Dec 2020 22:13:51 +0000 (23:13 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 9 Dec 2020 23:50:38 +0000 (15:50 -0800)
commita770bf515613c6e12ae904c3593e26016de99448
tree070e9e0651e009cf87054dbdad0e7796b35fbb7c
parenta379b01cd4b2aa3f12786b281a714871574e5ccb
ethtool: fix stack overflow in ethnl_parse_bitset()

Syzbot reported a stack overflow in bitmap_from_arr32() called from
ethnl_parse_bitset() when bitset from netlink message is longer than
target bitmap length. While ethnl_compact_sanity_checks() makes sure that
trailing part is all zeros (i.e. the request does not try to touch bits
kernel does not recognize), we also need to cap change_bits to nbits so
that we don't try to write past the prepared bitmaps.

Fixes: 88db6d1e4f62 ("ethtool: add ethnl_parse_bitset() helper")
Reported-by: syzbot+9d39fa49d4df294aab93@syzkaller.appspotmail.com
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Link: https://lore.kernel.org/r/3487ee3a98e14cd526f55b6caaa959d2dcbcad9f.1607465316.git.mkubecek@suse.cz
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/bitset.c