OSDN Git Service

net: qualcomm: rmnet: Fix incorrect UL checksum offload logic
authorSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Thu, 25 Jul 2019 18:07:12 +0000 (12:07 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jul 2019 21:20:06 +0000 (14:20 -0700)
commita7cf3d24ee6081930feb4c830a7f6f16ebe31c49
treec48c6b6df8e7a7e7f7f53c59d090ebccc7103651
parent01f5bffad555f8e22a61f4b1261fe09cf1b96994
net: qualcomm: rmnet: Fix incorrect UL checksum offload logic

The udp_ip4_ind bit is set only for IPv4 UDP non-fragmented packets
so that the hardware can flip the checksum to 0xFFFF if the computed
checksum is 0 per RFC768.

However, this bit had to be set for IPv6 UDP non fragmented packets
as well per hardware requirements. Otherwise, IPv6 UDP packets
with computed checksum as 0 were transmitted by hardware and were
dropped in the network.

In addition to setting this bit for IPv6 UDP, the field is also
appropriately renamed to udp_ind as part of this change.

Fixes: 5eb5f8608ef1 ("net: qualcomm: rmnet: Add support for TX checksum offload")
Cc: Sean Tranchetti <stranche@codeaurora.org>
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c
include/linux/if_rmnet.h