OSDN Git Service

selftests/bpf: fix incorrect users of create_and_get_cgroup
authorStanislav Fomichev <sdf@google.com>
Mon, 7 Jan 2019 17:46:46 +0000 (09:46 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 7 Jan 2019 21:15:55 +0000 (13:15 -0800)
commita8911d6d5878587767a78c6bde371298ca2a3be3
tree85d622fbc4afb974a19887bc1dd2d92f3573816e
parent97274b6126193cca2b820579f5d758589a2badc2
selftests/bpf: fix incorrect users of create_and_get_cgroup

We have some tests that assume create_and_get_cgroup returns -1 on error
which is incorrect (it returns 0 on error). Since fd might be zero in
general case, change create_and_get_cgroup to return -1 on error
and fix the users that assume 0 on error.

Fixes: f269099a7e7a ("tools/bpf: add a selftest for bpf_get_current_cgroup_id() helper")
Fixes: 7d2c6cfc5411 ("bpf: use --cgroup in test_suite if supplied")

v2:
- instead of fixing the uses that assume -1 on error, convert the users
  that assume 0 on error (fd might be zero in general case)

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
12 files changed:
samples/bpf/test_cgrp2_attach2.c
samples/bpf/test_current_task_under_cgroup_user.c
tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/test_cgroup_storage.c
tools/testing/selftests/bpf/test_dev_cgroup.c
tools/testing/selftests/bpf/test_netcnt.c
tools/testing/selftests/bpf/test_skb_cgroup_id_user.c
tools/testing/selftests/bpf/test_sock.c
tools/testing/selftests/bpf/test_sock_addr.c
tools/testing/selftests/bpf/test_socket_cookie.c
tools/testing/selftests/bpf/test_tcpbpf_user.c
tools/testing/selftests/bpf/test_tcpnotify_user.c