OSDN Git Service

USB: serial: digi_acceleport: fix OOB-event processing
authorJohan Hovold <johan@kernel.org>
Fri, 24 Feb 2017 18:11:28 +0000 (19:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Mar 2017 11:09:56 +0000 (19:09 +0800)
commita8cb5c02a20f04d947e386bdd958e1e80e920baa
tree83a76f2abfd59d602706ed58ebe979c6c7ecafcb
parent4d95645f3dd5b1e8453d65220f604c39e822d990
USB: serial: digi_acceleport: fix OOB-event processing

commit 2e46565cf622dd0534a9d8bffe152a577b48d7aa upstream.

A recent change claimed to fix an off-by-one error in the OOB-port
completion handler, but instead introduced such an error. This could
specifically led to modem-status changes going unnoticed, effectively
breaking TIOCMGET.

Note that the offending commit fixes a loop-condition underflow and is
marked for stable, but should not be backported without this fix.

Reported-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 2d380889215f ("USB: serial: digi_acceleport: fix OOB data sanity
check")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/digi_acceleport.c