OSDN Git Service

ixgbevf: Use smp_rmb rather than read_barrier_depends
authorBrian King <brking@linux.vnet.ibm.com>
Fri, 17 Nov 2017 17:05:45 +0000 (11:05 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Nov 2017 08:37:24 +0000 (08:37 +0000)
commita8e699dfca04191e209a63d484e347aa921422e2
treeb3d7970bead50b35d9d59e1367093e017c944300
parent2f7de4d5f525fc39c83e6c423e12f1954106bf38
ixgbevf: Use smp_rmb rather than read_barrier_depends

commit ae0c585d93dfaf923d2c7eb44b2c3ab92854ea9b upstream.

The original issue being fixed in this patch was seen with the ixgbe
driver, but the same issue exists with ixgbevf as well, as the code is
very similar. read_barrier_depends is not sufficient to ensure
loads following it are not speculatively loaded out of order
by the CPU, which can result in stale data being loaded, causing
potential system crashes.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c