OSDN Git Service

ALSA: ppc: beep: fix clang -Wimplicit-fallthrough
authorAnders Roxell <anders.roxell@linaro.org>
Tue, 7 Dec 2021 11:00:53 +0000 (12:00 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 7 Dec 2021 14:36:56 +0000 (15:36 +0100)
commita98478f825862ddc1686a3335f9f1cc278fc5733
treed507c8d74f9008a66bc90c1fd62c340d5c8324ae
parentc7d58971dbea0888b6328ed0ea61089a6d62253a
ALSA: ppc: beep: fix clang -Wimplicit-fallthrough

Clang warns:

sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
        case SND_TONE: break;
        ^
sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through
        case SND_TONE: break;
        ^
        break;
1 warning generated.

Clang is more pedantic than GCC, which does not warn when failing
through to a case that is just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst.
Add athe missing break to silence the warning.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Link: https://lore.kernel.org/r/20211207110053.695712-1-anders.roxell@linaro.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/beep.c