OSDN Git Service

workqueue: don't use wq_select_unbound_cpu() for bound works
authorHillf Danton <hdanton@sina.com>
Sat, 25 Jan 2020 01:14:45 +0000 (20:14 -0500)
committerTejun Heo <tj@kernel.org>
Tue, 10 Mar 2020 14:30:51 +0000 (10:30 -0400)
commitaa202f1f56960c60e7befaa0f49c72b8fa11b0a8
tree4666dc8751cd9751ac29f07b96e083ae9bb29f48
parentdbb92f88648d6206bf22fcb764fb9fe2939d401a
workqueue: don't use wq_select_unbound_cpu() for bound works

wq_select_unbound_cpu() is designed for unbound workqueues only, but
it's wrongly called when using a bound workqueue too.

Fixing this ensures work queued to a bound workqueue with
cpu=WORK_CPU_UNBOUND always runs on the local CPU.

Before, that would happen only if wq_unbound_cpumask happened to include
it (likely almost always the case), or was empty, or we got lucky with
forced round-robin placement.  So restricting
/sys/devices/virtual/workqueue/cpumask to a small subset of a machine's
CPUs would cause some bound work items to run unexpectedly there.

Fixes: ef557180447f ("workqueue: schedule WORK_CPU_UNBOUND work on wq_unbound_cpumask CPUs")
Cc: stable@vger.kernel.org # v4.5+
Signed-off-by: Hillf Danton <hdanton@sina.com>
[dj: massage changelog]
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c