OSDN Git Service

tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
authorStefan Berger <stefanb@linux.ibm.com>
Tue, 26 Nov 2019 13:17:53 +0000 (08:17 -0500)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Mon, 6 Jan 2020 17:36:09 +0000 (19:36 +0200)
commitaa4a63dd981682b1742baa01237036e48bc11923
treedab3e72251d8d1705f4628a0728189821b81a95f
parentdda8b2af395b2ed508e2ef314ae32e122841b447
tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"

There has been a bunch of reports (one from kernel bugzilla linked)
reporting that when this commit is applied it causes on some machines
boot freezes.

Unfortunately hardware where this commit causes a failure is not widely
available (only one I'm aware is Lenovo T490), which means we cannot
predict yet how long it will take to properly fix tpm_tis interrupt
probing.

Thus, the least worst short term action is to revert the code to the
state before this commit. In long term we need fix the tpm_tis probing
code to work on machines that Stefan's fix was supposed to fix.

Fixes: 21df4a8b6018 ("tpm_tis: reserve chip for duration of tpm_tis_core_init")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=205935
Cc: stable@vger.kernel.org
Cc: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Tested-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Xiaoping Zhou <xiaoping.zhou@intel.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reported-by: Jerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis_core.c