OSDN Git Service

9pfs: local: clarify fchmodat_nofollow() implementation
authorGreg Kurz <groug@kaod.org>
Mon, 4 Sep 2017 07:24:53 +0000 (09:24 +0200)
committerGreg Kurz <groug@kaod.org>
Tue, 5 Sep 2017 15:56:58 +0000 (17:56 +0200)
commitaa5e85a10846636165592c5a46d797c100c68529
tree9b5de8cc3ed8f662fd325f341294c96a9d880445
parent3c08f4a4335c325295d738d4090665b8617ab599
9pfs: local: clarify fchmodat_nofollow() implementation

Since fchmodat(2) on Linux doesn't support AT_SYMLINK_NOFOLLOW, we have to
implement it using workarounds. There are two different ways, depending on
whether the system supports O_PATH or not.

In the case O_PATH is supported, we rely on the behavhior of openat(2)
when passing O_NOFOLLOW | O_PATH and the file is a symbolic link. Even
if openat_file() already adds O_NOFOLLOW to the flags, this patch makes
it explicit that we need both creation flags to obtain the expected
behavior.

This is only cleanup, no functional change.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
hw/9pfs/9p-local.c