OSDN Git Service

nfsd: fix NULL dereference in nfs3svc_encode_getaclres
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 2 Jul 2021 00:06:56 +0000 (20:06 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 7 Jul 2021 00:14:44 +0000 (20:14 -0400)
commitab1016d39cc052064e32f25ad18ef8767a0ee3b8
tree7dd5b888b9dd16399cbc36b9c3d9eb980f19d342
parent7b08cf62b1239a4322427d677ea9363f0ab677c6
nfsd: fix NULL dereference in nfs3svc_encode_getaclres

In error cases the dentry may be NULL.

Before 20798dfe249a, the encoder also checked dentry and
d_really_is_positive(dentry), but that looks like overkill to me--zero
status should be enough to guarantee a positive dentry.

This isn't the first time we've seen an error-case NULL dereference
hidden in the initialization of a local variable in an xdr encoder.  But
I went back through the other recent rewrites and didn't spot any
similar bugs.

Reported-by: JianHong Yin <jiyin@redhat.com>
Reviewed-by: Chuck Lever III <chuck.lever@oracle.com>
Fixes: 20798dfe249a ("NFSD: Update the NFSv3 GETACL result encoder...")
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs3acl.c