OSDN Git Service

scripts/bpf: Print an error when known types list needs updating
authorJakub Sitnicki <jakub@cloudflare.com>
Sun, 20 Oct 2019 11:23:44 +0000 (13:23 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 21 Oct 2019 01:21:21 +0000 (18:21 -0700)
commitab81e203bc0d4a4542bca2498535f8761a3cfd92
tree026ff65fd5b453ef4e73a4281671ac45ae1d0da1
parent54b8625cd940b6baace0bd9b1cf26b2de68ba307
scripts/bpf: Print an error when known types list needs updating

Don't generate a broken bpf_helper_defs.h header if the helper script needs
updating because it doesn't recognize a newly added type. Instead print an
error that explains why the build is failing, clean up the partially
generated header and stop.

v1->v2:
- Switched from temporary file to .DELETE_ON_ERROR.

Fixes: 456a513bb5d4 ("scripts/bpf: Emit an #error directive known types list needs updating")
Suggested-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20191020112344.19395-1-jakub@cloudflare.com
scripts/bpf_helpers_doc.py
tools/lib/bpf/Makefile