OSDN Git Service

spi: spidev: fix a race between spidev_release and spidev_remove
authorZhenzhong Duan <zhenzhong.duan@gmail.com>
Thu, 18 Jun 2020 03:21:24 +0000 (11:21 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 18 Jun 2020 16:46:59 +0000 (17:46 +0100)
commitabd42781c3d2155868821f1b947ae45bbc33330d
treeeb27f5bb3c2d4720aa8832d9c1886eea08a21ed5
parent35700e221b18fa53401e5f315be90af9e0bbcdca
spi: spidev: fix a race between spidev_release and spidev_remove

Imagine below scene, spidev is referenced after it's freed.

spidev_release()                spidev_remove()
...
                                spin_lock_irq(&spidev->spi_lock);
                                    spidev->spi = NULL;
                                spin_unlock_irq(&spidev->spi_lock);
mutex_lock(&device_list_lock);
dofree = (spidev->spi == NULL);
if (dofree)
    kfree(spidev);
mutex_unlock(&device_list_lock);
                                mutex_lock(&device_list_lock);
                                list_del(&spidev->device_entry);
                                device_destroy(spidev_class, spidev->devt);
                                clear_bit(MINOR(spidev->devt), minors);
                                if (spidev->users == 0)
                                    kfree(spidev);
                                mutex_unlock(&device_list_lock);

Fix it by resetting spidev->spi in device_list_lock's protection.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Link: https://lore.kernel.org/r/20200618032125.4650-1-zhenzhong.duan@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spidev.c