OSDN Git Service

drm/amd/powerplay/hwmgr: don't add invalid voltage
authorMoritz Kühner <kuehner.moritz@gmail.com>
Sun, 17 Apr 2016 14:15:24 +0000 (16:15 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 5 May 2016 00:30:27 +0000 (20:30 -0400)
commitac0cc35008d570f5338b72f48960467c764b0f36
tree98637a8e4ffd4a0b8dce595efb3ed907527a1c95
parentc790f87318337738208b0a32697d88312a26086c
drm/amd/powerplay/hwmgr: don't add invalid voltage

if atomctrl_get_voltage_evv_on_sclk returns non zero (fail) in the expansion
of the PP_ASSERT_WITH_CODE macro the continue will actually do nothing
(The macro uses a do ... while(0) as scope, which eats the continue).
Based on the code I don't think this was the intent.
Unfortunately fixing this requires rewriting the control flow and
removing the macros.

v2: added signed of by
fixed error message print

v3: agd: drop DRM_ERROR

Signed-off-by: Moritz Kühner <kuehner.moritz@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c