OSDN Git Service

reiserfs: fix race in prealloc discard
authorJeff Mahoney <jeffm@suse.com>
Thu, 22 Jun 2017 20:47:34 +0000 (16:47 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jan 2018 11:06:11 +0000 (12:06 +0100)
commitac125d89f8e980f100f63634a81b84fed7e997cf
tree9e4ee58da1278f2799d023c2e419aaa2606a9eb5
parent8e8224de0e1848a5905ebda018969e2ce72258ca
reiserfs: fix race in prealloc discard

commit 08db141b5313ac2f64b844fb5725b8d81744b417 upstream.

The main loop in __discard_prealloc is protected by the reiserfs write lock
which is dropped across schedules like the BKL it replaced.  The problem is
that it checks the value, calls a routine that schedules, and then adjusts
the state.  As a result, two threads that are calling
reiserfs_prealloc_discard at the same time can race when one calls
reiserfs_free_prealloc_block, the lock is dropped, and the other calls
reiserfs_free_prealloc_block with the same block number.  In the right
circumstances, it can cause the prealloc count to go negative.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/reiserfs/bitmap.c