OSDN Git Service

s390/qdio: don't touch the dsci in tiqdio_add_input_queues()
authorJulian Wiedmann <jwi@linux.ibm.com>
Tue, 18 Jun 2019 11:12:20 +0000 (13:12 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Tue, 2 Jul 2019 14:00:27 +0000 (16:00 +0200)
commitac6639cd3db607d386616487902b4cc1850a7be5
tree631fa7eeaa6bed821208ebc16b315628e702ced3
parente54e4785cb5cb4896cf4285964aeef2125612fb2
s390/qdio: don't touch the dsci in tiqdio_add_input_queues()

Current code sets the dsci to 0x00000080. Which doesn't make any sense,
as the indicator area is located in the _left-most_ byte.

Worse: if the dsci is the _shared_ indicator, this potentially clears
the indication of activity for a _different_ device.
tiqdio_thinint_handler() will then have no reason to call that device's
IRQ handler, and the device ends up stalling.

Fixes: d0c9d4a89fff ("[S390] qdio: set correct bit in dsci")
Cc: <stable@vger.kernel.org>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
drivers/s390/cio/qdio_thinint.c