OSDN Git Service

QS - Fix race condition in accessibility
authordooyoung.hwang <dooyoung.hwang@lge.com>
Thu, 22 Dec 2016 11:04:20 +0000 (20:04 +0900)
committerAdrian Roos <roosa@google.com>
Wed, 28 Dec 2016 23:34:23 +0000 (15:34 -0800)
commitacf90acf137f236db7cf6df8d7c67228ec2c131b
tree65903fa979dcd116960502e734849212ed1d9a85
parent2f157c421a9fa15660b8f1bc0c64b1ebb45fa64a
QS - Fix race condition in accessibility

When users try to open panel, initialization of accessibility is called
in Main Thread by this callstack.

at android.view.ViewGroup.buildOrderedChildList
at android.view.View.populateAccessibilityNodeInfoDrawingOrderInParent
at android.view.View.onInitializeAccessibilityNodeInfoInternal
at android.view.View.onInitializeAccessibilityNodeInfo
at android.view.View.createAccessibilityNodeInfoInternal
at android.view.View.createAccessibilityNodeInfo
at android.view.accessibility.AccessibilityRecord.setSource
...
at android.view.View.setFlags
at android.view.View.setVisibility
at com.android.systemui.qs.QSContainer.updateQsState
at com.android.systemui.qs.QSContainer.setExpanded
at com.android.systemui.statusbar.phone.NotificationPanelView.updateQsState

And another initialization is tried in QSTileHost Thread by this callstack.

at android.view.ViewGroup.buildOrderedChildList
at android.view.View.populateAccessibilityNodeInfoDrawingOrderInParent
at android.view.View.onInitializeAccessibilityNodeInfoInternal
at android.view.ViewGroup.onInitializeAccessibilityNodeInfoInternal
at android.view.View.onInitializeAccessibilityNodeInfo
at android.view.View.createAccessibilityNodeInfoInternal
at android.view.View.createAccessibilityNodeInfo
at android.view.accessibility.AccessibilityRecord.setSource
...
at android.view.View.announceForAccessibility
at com.android.systemui.qs.QSPanel.onAnnouncementRequested
at com.android.systemui.qs.QSTile.handleStateChanged

This race condition can cause crashes, because the same ArrayList
(mPreSortedChildren or mTempArrayList in ViewGroup) is modified by two
different thread.

Test : manual

Change-Id: I9e0ad1fef4be7dc378463c06d10854e0e4c5b3d6
Fixes: 33947140
(cherry picked from commit 1b0066230edee70aa58bb866ba9b59a4a68690fc)
packages/SystemUI/src/com/android/systemui/qs/QSPanel.java