OSDN Git Service

scsi: core: Use eh_timeout for START STOP UNIT
authorChunguang Xu <brookxu@tencent.com>
Wed, 10 Nov 2021 01:23:32 +0000 (09:23 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 19 Nov 2021 03:26:58 +0000 (22:26 -0500)
commitadcc796b4f55c18ee5fca8190a592c84cf8682e0
treec73e05b34e43a44119ec034102b89c371b6646ca
parent0a84486d6c1da1c2738544d8fc1b07b1d3ce046f
scsi: core: Use eh_timeout for START STOP UNIT

In some scenarios START STOP UNIT may time out. The default recovery
time of 30 seconds is relatively large. Modifying rq_timeout to adjust
the START STOP UNIT timeout value will affect the regular I/O.

Commit 9728c0814ecb ("[SCSI] make scsi_eh_try_stu use block timeout")
switched to rq_timeout for the START STOP UNIT command. However commit
0816c9251a71 ("[SCSI] Allow error handling timeout to be specified")
introduced an explicit eh_timeout parameter. It makes more sense to
use this value as the timeout for START STOP UNIT.

Link: https://lore.kernel.org/r/1636507412-21678-1-git-send-email-brookxu.cn@gmail.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Wu Bo <wubo40@huawei.com>
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_error.c