OSDN Git Service

RDMA/qedr: Remove enumerated type qed_roce_ll2_tx_dest
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 27 Sep 2018 20:55:58 +0000 (13:55 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 1 Oct 2018 01:21:11 +0000 (19:21 -0600)
commitaef716fa5e6da3919cca22ac2097a90d73d8177f
tree248ab30eb4706ea1f3f2b9479b18ec7fb7cc5b94
parent935c84ac649a147e1aad2c48ee5c5a1a9176b2d0
RDMA/qedr: Remove enumerated type qed_roce_ll2_tx_dest

Clang warns when one enumerated type is explicitly converted to another.

drivers/infiniband/hw/qedr/qedr_roce_cm.c:198:28: warning: implicit
conversion from enumeration type 'enum qed_roce_ll2_tx_dest' to
different enumeration type 'enum qed_ll2_tx_dest' [-Wenum-conversion]
        ll2_tx_pkt.tx_dest = pkt->tx_dest;
                           ~ ~~~~~^~~~~~~
1 warning generated.

Turns out that QED_ROCE_LL2_TX_DEST_NW and QED_ROCE_LL2_TX_DEST_LB are
only used once in the whole tree and QED_ROCE_LL2_TX_DEST_MAX is used
nowhere. Remove them and use the equivalent values from qed_ll2_tx_dest
in their place.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Michal Kalderon <michal.kalderon@cavium.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/qedr/qedr_roce_cm.c
include/linux/qed/qed_rdma_if.h