OSDN Git Service

mwifiex: prevent an array overflow
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Apr 2019 08:44:23 +0000 (11:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jun 2019 10:23:55 +0000 (12:23 +0200)
commitaf2fb022b390da9b8e3e068bc176a1547584949f
treeb71861bdabfef382e9184848a81b8bfb31e97f82
parent4b24af0936314bc0e0bd8aa6d45ea11df83db4d2
mwifiex: prevent an array overflow

[ Upstream commit b4c35c17227fe437ded17ce683a6927845f8c4a4 ]

The "rate_index" is only used as an index into the phist_data->rx_rate[]
array in the mwifiex_hist_data_set() function.  That array has
MWIFIEX_MAX_AC_RX_RATES (74) elements and it's used to generate some
debugfs information.  The "rate_index" variable comes from the network
skb->data[] and it is a u8 so it's in the 0-255 range.  We need to cap
it to prevent an array overflow.

Fixes: cbf6e05527a7 ("mwifiex: add rx histogram statistics support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/mwifiex/cfp.c