OSDN Git Service

mmc: spi: Toggle SPI polarity, do not hardcode it
authorLinus Walleij <linus.walleij@linaro.org>
Wed, 4 Dec 2019 15:27:49 +0000 (16:27 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 16 Dec 2019 11:29:05 +0000 (12:29 +0100)
commitaf3ed119329cf9690598c5a562d95dfd128e91d6
tree50877c05a8b81be132b6c506b6f9677de09acd72
parent3976656d67c1e47a5deb25f2c2fdc188dd97dbd7
mmc: spi: Toggle SPI polarity, do not hardcode it

The code in mmc_spi_initsequence() tries to send a burst with
high chipselect and for this reason hardcodes the device into
SPI_CS_HIGH.

This is not good because the SPI_CS_HIGH flag indicates
logical "asserted" CS not always the physical level. In
some cases the signal is inverted in the GPIO library and
in that case SPI_CS_HIGH is already set, and enforcing
SPI_CS_HIGH again will actually drive it low.

Instead of hard-coding this, toggle the polarity so if the
default is LOW it goes high to assert chipselect but if it
is already high then toggle it low instead.

Cc: Phil Elwell <phil@raspberrypi.org>
Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20191204152749.12652-1-linus.walleij@linaro.org
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mmc_spi.c