OSDN Git Service

nvme-tcp: fix kconfig dependency warning when !CRYPTO
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Mon, 14 Sep 2020 15:01:21 +0000 (18:01 +0300)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Sep 2020 05:58:49 +0000 (07:58 +0200)
commitaf5ad17854f96a6d3c9775e776bd01ab262672a1
treef9c9949a18c2cbc4dcd93f52639e6acbd30964f6
parentce4cc3133dc72c31bd49ddcf22d0f9eeff47a761
nvme-tcp: fix kconfig dependency warning when !CRYPTO

When NVME_TCP is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_CRC32C
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y]

The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or
selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 79fd751d61aa ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/Kconfig