OSDN Git Service

net: dsa: mv88e6xxx: Require ops be implemented to claim STU support
authorTobias Waldekranz <tobias@waldekranz.com>
Fri, 18 Mar 2022 20:13:20 +0000 (21:13 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 21 Mar 2022 22:51:50 +0000 (15:51 -0700)
commitafaed2b142a1ab896764b03d8d26dc8778ea887c
tree5517e3c48f44c97880479534376b7609df1230ce
parente0c0ca3546adf6aaa9ba7c7232bd3b1792f3153b
net: dsa: mv88e6xxx: Require ops be implemented to claim STU support

Simply having a physical STU table in the device doesn't do us any
good if there's no implementation of the relevant ops to access that
table. So ensure that chips that claim STU support can also talk to
the hardware.

This fixes an issue where chips that had a their ->info->max_sid
set (due to their family membership), but no implementation (due to
their chip-specific ops struct) would fail to probe.

Fixes: 49c98c1dc7d9 ("net: dsa: mv88e6xxx: Disentangle STU from VTU")
Reported-by: Marek BehĂșn <kabel@kernel.org>
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Marek BehĂșn <kabel@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/chip.h