OSDN Git Service

cpuidle: Fix cpuidle_driver_state_disabled()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Dec 2019 11:48:35 +0000 (12:48 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 10 Dec 2019 22:41:20 +0000 (23:41 +0100)
commitb0142d66f4edb8578b7772d6d7ad731836b82ddb
treed5e9cfeb7782e390392c0956ed9b12e9744fdd8c
parent36fcb4292473cb9c9ce7706d038bcf0eda5cabeb
cpuidle: Fix cpuidle_driver_state_disabled()

It turns out that cpuidle_driver_state_disabled() can be called
before registering the cpufreq driver on some platforms, which
was not expected when it was introduced and which leads to a NULL
pointer dereference when trying to walk the CPUs associated with
the given cpuidle driver.

Fix the problem by making cpuidle_driver_state_disabled() check if
the driver's mask of CPUs associated with it is present and to set
CPUIDLE_FLAG_UNUSABLE for the given idle state in the driver's states
list if that is not the case to cause __cpuidle_register_device() to
set CPUIDLE_STATE_DISABLED_BY_DRIVER for that state for all cpuidle
devices registered by it later.

Fixes: cbda56d5fefc ("cpuidle: Introduce cpuidle_driver_state_disabled() for driver quirks")
Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Tested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/driver.c