OSDN Git Service

bnxt_en: reject indirect blk offload when hw-tc-offload is off
authorSriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Mon, 15 Nov 2021 07:38:01 +0000 (02:38 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Nov 2021 14:13:20 +0000 (14:13 +0000)
commitb0757491a118ae5727cf9f1c3a11544397d46596
tree7b5030ed97b3c199eaadd47af9a06f04633dfa15
parentb68a1a933fe4a52a8316d214e3421f2a89bc113e
bnxt_en: reject indirect blk offload when hw-tc-offload is off

The driver does not check if hw-tc-offload is enabled for the device
before offloading a flow in the context of indirect block callback.
Fix this by checking NETIF_F_HW_TC in the features flag and rejecting
the offload request.  This will avoid unnecessary dmesg error logs when
hw-tc-offload is disabled, such as these:

bnxt_en 0000:19:00.1 eno2np1: dev(ifindex=294) not on same switch
bnxt_en 0000:19:00.1 eno2np1: Error: bnxt_tc_add_flow: cookie=0xffff8dace1c88000 error=-22
bnxt_en 0000:19:00.0 eno1np0: dev(ifindex=294) not on same switch
bnxt_en 0000:19:00.0 eno1np0: Error: bnxt_tc_add_flow: cookie=0xffff8dace1c88000 error=-22

Reported-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Fixes: 627c89d00fb9 ("bnxt_en: flow_offload: offload tunnel decap rules via indirect callbacks")
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c