OSDN Git Service

drm/qxl: handle NULL bo->resource in move callback
authorMatthew Auld <matthew.auld@intel.com>
Wed, 8 Feb 2023 14:53:17 +0000 (14:53 +0000)
committerChristian König <christian.koenig@amd.com>
Thu, 23 Feb 2023 09:29:14 +0000 (10:29 +0100)
commitb129ff30acea495b1455cf8d6e1d86fdb87d22d4
treee21f281f11d0cb6c3baa4bb0e04fb5174c276a7d
parentc604d31950d10db45267bbcb9ce8f1dbc2bfa74e
drm/qxl: handle NULL bo->resource in move callback

The ttm bo now initially has NULL bo->resource, and leaves the driver
the handle that. However it looks like we forgot to handle that for qxl.
It looks like this will just null-ptr-deref in qxl_bo_move(), if
bo->resource is NULL.

Fix this by calling move_null() if the new resource is TTM_PL_SYSTEM,
otherwise do the multi-hop sequence to ensure can safely call into
ttm_bo_move_memcpy(), since it might also need to clear the memory.
This should give the same behaviour as before.

Fixes: 180253782038 ("drm/ttm: stop allocating dummy resources during BO creation")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230208145319.397235-2-matthew.auld@intel.com
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/qxl/qxl_ttm.c