OSDN Git Service

team: Fix double free in error path
authorArkadi Sharshevsky <arkadis@mellanox.com>
Thu, 8 Mar 2018 10:42:10 +0000 (12:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Mar 2018 16:11:34 +0000 (18:11 +0200)
commitb14031144e37fd5f53a6a4a1359d91b0210ca47f
treecea23d61bb9f780e53790371005102bc521fd381
parentd5862b05903c8b1f49dab92683872854581b9812
team: Fix double free in error path

[ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ]

The __send_and_alloc_skb() receives a skb ptr as a parameter but in
case it fails the skb is not valid:
- Send failed and released the skb internally.
- Allocation failed.

The current code tries to release the skb in case of failure which
causes redundant freeing.

Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/team/team.c