OSDN Git Service

s390/gmap: don't unconditionally call pte_unmap_unlock() in __gmap_zap()
authorDavid Hildenbrand <david@redhat.com>
Thu, 9 Sep 2021 16:22:41 +0000 (18:22 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 25 Oct 2021 07:20:38 +0000 (09:20 +0200)
commitb159f94c86b43cf7e73e654bc527255b1f4eafc4
tree2c25f796861da3dc1c2f18038edb32b623ea4af3
parent2d8fb8f3914b40e3cc12f8cbb74daefd5245349d
s390/gmap: don't unconditionally call pte_unmap_unlock() in __gmap_zap()

... otherwise we will try unlocking a spinlock that was never locked via a
garbage pointer.

At the time we reach this code path, we usually successfully looked up
a PGSTE already; however, evil user space could have manipulated the VMA
layout in the meantime and triggered removal of the page table.

Fixes: 1e133ab296f3 ("s390/mm: split arch/s390/mm/pgtable.c")
Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20210909162248.14969-3-david@redhat.com
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/mm/gmap.c