OSDN Git Service

Convert xml based API allowDynamicSummaryInSlice to java
authorFan Zhang <zhfan@google.com>
Fri, 29 Mar 2019 22:43:46 +0000 (15:43 -0700)
committerFan Zhang <zhfan@google.com>
Mon, 1 Apr 2019 19:39:30 +0000 (12:39 -0700)
commitb1b07e2030a1a1010fbba70699c8d265a6af9fd6
tree0c64577e779a5af75b5203bdbde99aa4d9bc4000
parent961f038c4d4098516cc218d3e76d41f2cbb98f9d
Convert xml based API allowDynamicSummaryInSlice to java

- Add boolean useDynamicSliceSummary() in Sliceable interface. This is
  the switch equivalent to android:allowDynamicSummaryInSlice in xml. It
  moves the setter closer to regular Sliceable APIs, thus less easily to
  miss.
- Coverted all android:allowDynamicSummaryInSlice to use the java API.
  - Except 2 prefs in my_device_info. They incorrectly set this to true
  previously (controller is not sliceable, no point setting
  dynamicSliceSummary to true. They just won't do anything)

Fixes: 128446156
Test: robolectric
Change-Id: Ic57acd590dec3e87dcf4592df137321d14b854d9
38 files changed:
res/values/attrs.xml
res/xml/firmware_version.xml
res/xml/hardware_info.xml
res/xml/my_device_info.xml
res/xml/sound_settings.xml
src/com/android/settings/core/PreferenceXmlParserUtils.java
src/com/android/settings/deviceinfo/PhoneNumberPreferenceController.java
src/com/android/settings/deviceinfo/firmwareversion/FirmwareVersionDetailPreferenceController.java
src/com/android/settings/deviceinfo/firmwareversion/SimpleBuildNumberPreferenceController.java
src/com/android/settings/deviceinfo/hardwareinfo/DeviceModelPreferenceController.java
src/com/android/settings/deviceinfo/hardwareinfo/HardwareRevisionPreferenceController.java
src/com/android/settings/deviceinfo/hardwareinfo/SerialNumberPreferenceController.java
src/com/android/settings/deviceinfo/imei/ImeiInfoPreferenceController.java
src/com/android/settings/notification/AdjustVolumeRestrictedPreferenceController.java
src/com/android/settings/notification/AlarmVolumePreferenceController.java
src/com/android/settings/notification/CallVolumePreferenceController.java
src/com/android/settings/notification/MediaVolumePreferenceController.java
src/com/android/settings/notification/RemoteVolumePreferenceController.java
src/com/android/settings/notification/RingVolumePreferenceController.java
src/com/android/settings/search/SettingsSearchIndexablesProvider.java
src/com/android/settings/slices/SliceBuilderUtils.java
src/com/android/settings/slices/SliceData.java
src/com/android/settings/slices/SliceDataConverter.java
src/com/android/settings/slices/Sliceable.java
src/com/android/settings/slices/SlicesDatabaseAccessor.java
src/com/android/settings/slices/SlicesDatabaseHelper.java
src/com/android/settings/slices/SlicesIndexer.java
tests/robotests/res/xml-mcc998/location_settings.xml
tests/robotests/res/xml-mcc999/location_settings.xml
tests/robotests/src/com/android/settings/core/BadPreferenceController.java
tests/robotests/src/com/android/settings/core/PreferenceXmlParserUtilsTest.java
tests/robotests/src/com/android/settings/slices/FakePreferenceController.java
tests/robotests/src/com/android/settings/slices/SliceBuilderUtilsTest.java
tests/robotests/src/com/android/settings/slices/SliceDataConverterTest.java
tests/robotests/src/com/android/settings/slices/SliceDataTest.java
tests/robotests/src/com/android/settings/slices/SlicesDatabaseAccessorTest.java
tests/robotests/src/com/android/settings/slices/SlicesDatabaseHelperTest.java
tests/robotests/src/com/android/settings/slices/SlicesIndexerTest.java