OSDN Git Service

net: mv643xx_eth: fix orphaned statistics timer crash
authorSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Wed, 2 Oct 2013 10:57:21 +0000 (12:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Nov 2013 12:31:00 +0000 (04:31 -0800)
commitb24b4a82fc96f74d848275c8f1b33df66cbef061
treeb17e33bc6f447cd93fb65c2a789ee69c5eb7cd01
parent85cd02136ded01747a7959567aa1626627f1877e
net: mv643xx_eth: fix orphaned statistics timer crash

[ Upstream commit f564412c935111c583b787bcc18157377b208e2e ]

The periodic statistics timer gets started at port _probe() time, but
is stopped on _stop() only. In a modular environment, this can cause
the timer to access already deallocated memory, if the module is unloaded
without starting the eth device. To fix this, we add the timer right
before the port is started, instead of at _probe() time.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/marvell/mv643xx_eth.c