OSDN Git Service

(root) / android-x86 / frameworks-native.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9b36529) | patch
crash if getNativeBuffer() called on NULL GraphicBuffer
authorColin Cross <ccross@android.com>
Tue, 22 Jul 2014 22:55:08 +0000 (15:55 -0700)
committerThe Android Automerger <android-build@google.com>
Wed, 23 Jul 2014 21:47:55 +0000 (14:47 -0700)
commitb2aada6e8481575304f50594d715b8eeac1b54be
tree60cd1379e2a52764d85a678dbc5b4268586f33ebtree | snapshot
parent9b365296a745751c08731f369435e00682165f18commit | diff
crash if getNativeBuffer() called on NULL GraphicBuffer

If getNativeBuffer() is called on a NULL GraphicBuffer the
static_cast of this from GraphicBuffer* to ANativeWindowBuffer*
will return a small pointer like (ANativeWindowBuffer*)0x10.
This value can propagate past NULL checks until it causes a crash
far away from the original NULL pointer.  Crash immediately
instead.

Change-Id: Id614b9eb1484108b3c3c733545309844c4b87532
libs/ui/GraphicBuffer.cpp diff | blob | history
frameworks/native
About OSDN
Find Software
Develop Software
Help