OSDN Git Service

PM: Free memory bitmaps if opening /dev/snapshot fails
authorMichal Kubecek <mkubecek@suse.cz>
Sat, 18 Jun 2011 18:34:01 +0000 (20:34 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 9 Jul 2011 06:15:09 +0000 (23:15 -0700)
commitb2d786200219377e321c8281c46076b1db890763
treee6efacb93dff1b3fa6ae0ec92106c8d79ee75850
parentb50d3d6759c7912261c803d117d5d54dabaa40d4
PM: Free memory bitmaps if opening /dev/snapshot fails

commit 8440f4b19494467883f8541b7aa28c7bbf6ac92b upstream.

When opening /dev/snapshot device, snapshot_open() creates memory
bitmaps which are freed in snapshot_release(). But if any of the
callbacks called by pm_notifier_call_chain() returns NOTIFY_BAD, open()
fails, snapshot_release() is never called and bitmaps are not freed.
Next attempt to open /dev/snapshot then triggers BUG_ON() check in
create_basic_memory_bitmaps(). This happens e.g. when vmwatchdog module
is active on s390x.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/power/user.c