OSDN Git Service

nvme-fcloop: Fix dropped LS's to removed target port
authorJames Smart <jsmart2021@gmail.com>
Thu, 9 Aug 2018 23:00:14 +0000 (16:00 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Oct 2018 23:59:26 +0000 (16:59 -0700)
commitb32e647a83751bc24d7ef7522915005b2bac9200
treec72d5369249a1bdac62c1e39bb46e9f6d7863ffa
parent22670e847f7ca72a4e871d00eaa7c720ff94ef6f
nvme-fcloop: Fix dropped LS's to removed target port

[ Upstream commit afd299ca996929f4f98ac20da0044c0cdc124879 ]

When a targetport is removed from the config, fcloop will avoid calling
the LS done() routine thinking the targetport is gone. This leaves the
initiator reset/reconnect hanging as it waits for a status on the
Create_Association LS for the reconnect.

Change the filter in the LS callback path. If tport null (set when
failed validation before "sending to remote port"), be sure to call
done. This was the main bug. But, continue the logic that only calls
done if tport was set but there is no remoteport (e.g. case where
remoteport has been removed, thus host doesn't expect a completion).

Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvme/target/fcloop.c