OSDN Git Service

drm/meson: dw-hdmi: Ensure that clocks are enabled before touching the TOP registers
authorMarc Zyngier <maz@kernel.org>
Mon, 16 Nov 2020 20:07:44 +0000 (20:07 +0000)
committerNeil Armstrong <narmstrong@baylibre.com>
Tue, 17 Nov 2020 13:47:08 +0000 (14:47 +0100)
commitb33340e33acdfe5ca6a5aa1244709575ae1e0432
treebe8d7be962970dd39be85d1c207aa5832fe03f7f
parent0405f94a1ae0586ca237aec0e859f1b796d6325d
drm/meson: dw-hdmi: Ensure that clocks are enabled before touching the TOP registers

Removing the meson-dw-hdmi module and re-inserting it results in a hang
as the driver writes to HDMITX_TOP_SW_RESET. Similar effects can be seen
when booting with mainline u-boot and using the u-boot provided DT (which
is highly desirable).

The reason for the hang seem to be that the clocks are not always
enabled by the time we enter meson_dw_hdmi_init(). Moving this call
*after* dw_hdmi_probe() ensures that the clocks are enabled.

Fixes: 1374b8375c2e ("drm/meson: dw_hdmi: add resume/suspend hooks")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201116200744.495826-5-maz@kernel.org
drivers/gpu/drm/meson/meson_dw_hdmi.c