OSDN Git Service

media: cx88: Get rid of spurious call to cx8800_start_vbi_dma()
authorDevin Heitmueller <dheitmueller@kernellabs.com>
Tue, 24 Apr 2018 23:12:52 +0000 (19:12 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Sat, 5 May 2018 14:25:20 +0000 (10:25 -0400)
commitb3a78df581641fdbeb19c6ed162112fcf2ae48f7
tree6465a1d0469591ecbc6bf771bfe306ba6a79aee5
parent245c189dc9de2b4739ec2c50bb3c9a5405f7f4eb
media: cx88: Get rid of spurious call to cx8800_start_vbi_dma()

This was left over from the conversion to VB2, where the call was
getting invoked both in buffer_queue and start_streaming, which
was intermittently causing invalid opcodes on the VBI RISC queue.

This change effectively mirrors the exact same change Hans Verkuil
made in cx88-video.c in commit 389208e1173e ("[media] cx88:
remove leftover start_video_dma() call").

Thanks to Daniel Glöckner for spotting the actual bug after I spent
several days trying to chase down the issue.

Fixes: 389208e1173e ("[media] cx88: remove leftover start_video_dma() call")

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Thanks-to: Daniel Glöckner <daniel-gl@gmx.net>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx88/cx88-vbi.c