OSDN Git Service

ldso_tls: Refetch dtv from memory if THREAD_DTV has changed
authorCarmelo Amoroso <carmelo.amoroso@st.com>
Thu, 3 Dec 2009 12:33:16 +0000 (13:33 +0100)
committerCarmelo Amoroso <carmelo.amoroso@st.com>
Thu, 3 Dec 2009 12:33:16 +0000 (13:33 +0100)
commitb3d31460fbf188997c7337296a61409529f7c974
treeb451066b5b869f1d6941d5232ba4f97ad8e56c00
parentb93ab6041d56a5a19d8a97b69f6e3202fd11e859
ldso_tls: Refetch dtv from memory if THREAD_DTV has changed

_dl_update_slotinfo might change THREAD_DTV () (if it needs to reallocate it),
but the caller (__tls_get_addr) doesn't refetch dtv from memory, it uses its
cached copy. This may crash (if dtv[GET_ADDR_MODULE] is off the cliff, or
might read uninitialized memory and return it.
Typically dtv[GET_ADDR_MODULE].pointer.val is NULL and so __tls_get_addr
returns NULL + offset_within_PT_TLS. The next time __tls_get_addr is called
for the same library it will return correct address as _dl_update_slotinfo
won't need to be called.

Signed-off-by: Jakub Jelinek <jakub@redhat.com>
Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
Signed-off-by: Carmelo Amoroso <carmelo.amoroso@st.com>
ldso/ldso/dl-tls.c
test/tls/Makefile.in
test/tls/tst-tls18.c [new file with mode: 0644]
test/tls/tst-tlsmod18a.c [new file with mode: 0644]