OSDN Git Service

KVM: irqchip: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 31 May 2019 19:24:53 +0000 (14:24 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 5 Jun 2019 12:14:48 +0000 (14:14 +0200)
commitb3ffd74a2f6fbec131eff6d81bc7a6dbbac57bc7
treea1b4c463bb73b56fbbecc7d74fc1dfea4a86fdd7
parent5a253552a5108bcabc2eb4e5b2b86262232f17e7
KVM: irqchip: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
   int stuff;
   struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/irqchip.c