OSDN Git Service

net: phy: fix phy_validate_pause
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 1 May 2019 19:54:28 +0000 (21:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 May 2019 08:04:10 +0000 (01:04 -0700)
commitb4010af981ac8cdf1f7f58eb6b131c482e5dee02
tree7c346ca5f94d61b85fa58bf4399f639455252037
parent7fcd1e033dacedd520abebc943c960dcf5add3ae
net: phy: fix phy_validate_pause

We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't
need to be supported. Therefore extend the first check to check
for rx_pause being set.

See also phy_set_asym_pause:
rx=0 and tx=1: advertise asym pause only
rx=0 and tx=0: stop advertising both pause modes

The fixed commit isn't wrong, it's just the one that introduced the
linkmode bitmaps.

Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c