OSDN Git Service

clk: qcom: hfpll: CLK_IGNORE_UNUSED
authorJorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Mon, 25 Nov 2019 13:59:06 +0000 (14:59 +0100)
committerStephen Boyd <sboyd@kernel.org>
Thu, 19 Dec 2019 06:07:52 +0000 (22:07 -0800)
commitb455dc3510ca7070a07bd0119f4f432a98d1bc0b
tree75f453ded4516ae3b9963be92c940aafdb011990
parent9e4066748bf7bf13b04312f9b1c42d2a6cc77f66
clk: qcom: hfpll: CLK_IGNORE_UNUSED

When COMMON_CLK_DISABLED_UNUSED is set, in an effort to save power and
to keep the software model of the clock in line with reality, the
framework transverses the clock tree and disables those clocks that
were enabled by the firmware but have not been enabled by any device
driver.

If CPUFREQ is enabled, early during the system boot, it might attempt
to change the CPU frequency ("set_rate"). If the HFPLL is selected as
a provider, it will then change the rate for this clock.

As boot continues, clk_disable_unused_subtree will run. Since it wont
find a valid counter (enable_count) for a clock that is actually
enabled it will attempt to disable it which will cause the CPU to
stop. Notice that in this driver, calls to check whether the clock is
enabled are routed via the is_enabled callback which queries the
hardware.

The following commit, rather than marking the clock critical and
forcing the clock to be always enabled, addresses the above scenario
making sure the clock is not disabled but it continues to rely on the
firmware to enable the clock.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lkml.kernel.org/r/20191125135910.679310-5-niklas.cassel@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/qcom/hfpll.c