OSDN Git Service

drm/msm/gem: Drop early returns in close/purge vma
authorRob Clark <robdclark@chromium.org>
Fri, 10 Jun 2022 17:20:55 +0000 (10:20 -0700)
committerRob Clark <robdclark@chromium.org>
Wed, 15 Jun 2022 20:22:45 +0000 (13:22 -0700)
commitb4d329c451a299323b26039df97b32896fb46abc
treebd8ec55dacdb8418afcb7c4f45d3dc43b44ceaee
parent311e03c29c255665e10a31910308de3777f21274
drm/msm/gem: Drop early returns in close/purge vma

Keep the warn, but drop the early return.  If we do manage to hit this
sort of issue, skipping the cleanup just makes things worse (dangling
drm_mm_nodes when the msm_gem_vma is freed, etc).  Whereas the worst
that happens if we tear down a mapping the GPU is accessing is that we
get GPU iova faults, but otherwise the world keeps spinning.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Tested-by: Steev Klimaszewski <steev@kali.org>
Reported-by: Steev Klimaszewski <steev@kali.org>
Patchwork: https://patchwork.freedesktop.org/patch/489115/
Link: https://lore.kernel.org/r/20220610172055.2337977-1-robdclark@gmail.com
drivers/gpu/drm/msm/msm_gem_vma.c