OSDN Git Service

vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16,24,32}
authorGonglei <arei.gonglei@huawei.com>
Wed, 28 May 2014 13:21:35 +0000 (21:21 +0800)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 2 Jun 2014 14:30:52 +0000 (16:30 +0200)
commitb52991537c0efe27ee0c1955eb28a4584226d8b5
tree7dda35d44b58adf22bb35d8e845dfef961b1c5e7
parent4006617552892a1fe3a5a1f4d103613404abc409
vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16,24,32}

Spotted by Coverity:

(1) Event assignment:  Assigning: "pixels" = "0".
(2) Event cond_true:  Condition "y < h", taking true branch
(3) Event cond_false:  Condition "x < w", taking false branch
(4) Event loop_end:  Reached end of loop
(5) Event divide_by_zero:  In expression "(stats[0] + stats[1]) * 100U / pixels",
division by expression "pixels" which may be zero has undefined behavior.

290     DEFINE_DETECT_FUNCTION(16)
291     DEFINE_DETECT_FUNCTION(32)

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc-enc-tight.c