OSDN Git Service

net: Google gve: Remove dma_wmb() before ringing doorbell
authorLiran Alon <liran.alon@oracle.com>
Fri, 3 Jan 2020 16:44:59 +0000 (18:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Jan 2020 20:40:53 +0000 (12:40 -0800)
commitb54ef37b1ce892fdf6b632d566246d2f2f539910
treeb52c82984379aaab718a28a7004f9f6245abb374
parenteed70fd9452fe0fcd1a221731a4333b51a8081f2
net: Google gve: Remove dma_wmb() before ringing doorbell

Current code use dma_wmb() to ensure Rx/Tx descriptors are visible
to device before writing to doorbell.

However, these dma_wmb() are wrong and unnecessary. Therefore,
they should be removed.

iowrite32be() called from gve_rx_write_doorbell()/gve_tx_put_doorbell()
should guaratee that all previous writes to WB/UC memory is visible to
device before the write done by iowrite32be().

E.g. On ARM64, iowrite32be() calls __iowmb() which expands to dma_wmb()
and only then calls __raw_writel().

Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/google/gve/gve_rx.c
drivers/net/ethernet/google/gve/gve_tx.c