OSDN Git Service

drm/of: free the right object
authorJulia Lawall <Julia.Lawall@inria.fr>
Fri, 9 Jul 2021 20:07:17 +0000 (22:07 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 12 Jul 2021 14:25:53 +0000 (16:25 +0200)
commitb557a5f8da5798d27370ed6b73e673aae33efd55
tree6beedc6b7bb19cceb30898a164280428f1ba6111
parent7dc924d7c595b21c084644be6d18014aae505b0f
drm/of: free the right object

There is no need to free a NULL value.  Instead, free the object
that is leaking due to the iterator.

The semantic patch that finds this problem is as follows:

// <smpl>
@@
expression x,e;
identifier f;
@@
 x = f(...);
 if (x == NULL) {
... when any
    when != x = e
* of_node_put(x);
...
 }
// </smpl>

Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210709200717.3676376-1-Julia.Lawall@inria.fr
drivers/gpu/drm/drm_of.c