OSDN Git Service

net/af_iucv: Use struct_group() to zero struct iucv_sock region
authorKees Cook <keescook@chromium.org>
Thu, 18 Nov 2021 20:34:07 +0000 (12:34 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Nov 2021 11:52:25 +0000 (11:52 +0000)
commitb5d8cf0af167f3ab9f4cfe44918cde01e20a1222
tree1441f3c3a919ea466ff4405cf0be02e19e6c6611
parent8f2a83b454c9b17989843756313e0180827a7ace
net/af_iucv: Use struct_group() to zero struct iucv_sock region

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memset(), avoid intentionally writing across
neighboring fields.

Add struct_group() to mark the region of struct iucv_sock that gets
initialized to zero. Avoid the future warning:

In function 'fortify_memset_chk',
    inlined from 'iucv_sock_alloc' at net/iucv/af_iucv.c:476:2:
./include/linux/fortify-string.h:199:4: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
  199 |    __write_overflow_field(p_size_field, size);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Link: https://lore.kernel.org/lkml/19ff61a0-0cda-6000-ce56-dc6b367c00d6@linux.ibm.com/
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/iucv/af_iucv.h
net/iucv/af_iucv.c